Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect compliance calendar picker zindex #4412

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

scottopherson
Copy link
Contributor

Depending on the browser viewport size, the compliance calendar picker would render underneath the compliance tab menu. This commit adds a zindex to the calendar picker dropdown to correct this issue.

Before:
Screen Shot 2020-10-27 at 2 40 11 PM

After:
Screen Shot 2020-10-27 at 2 41 00 PM

@scottopherson scottopherson added bug 🐛 Something isn't working ui automate-ui labels Oct 27, 2020
@scottopherson scottopherson requested a review from a team October 27, 2020 18:49
@netlify
Copy link

netlify bot commented Oct 27, 2020

Deploy preview for chef-automate ready!

Built with commit 185bd5b

https://deploy-preview-4412--chef-automate.netlify.app

Depending on the browser viewport size, the compliance calendar picker would render underneath the compliance view tab menu. This commit adds a zindex to the calendar picker dropdown to correct this issue.

Signed-off-by: Scott Christopherson <scott@scott-christopherson.com>
Copy link
Contributor

@SEAjamieD SEAjamieD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working great 👍

@SEAjamieD SEAjamieD requested a review from a team October 27, 2020 20:51
Copy link
Contributor

@Shadae Shadae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - pulled it down and it works as described.

@scottopherson scottopherson merged commit 6ef0356 into master Oct 29, 2020
@scottopherson scottopherson deleted the sc/compliance-calender-zindex branch October 29, 2020 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automate-ui bug 🐛 Something isn't working ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants